Repository navigation
fix(reader): columnStats reports decimal min/max; decimals compare by value (#583) - #695
Merged
Merged
Conversation
… compare by value (#583) The zone-table decode boxed primitives, bools and strings but not decimals, so a decimal column (Java- or Rust-written) had no min/max in VortexReader.columnStats(), and zone-map pruning of decimal filters never fired. Compare also treated a BigDecimal as a Number and fell to the long compare, so 1.5 and 1.2 were equal. Decimal and unresolved-column compares now go by value, against another decimal or a long, big integer or finite float operand (anything else throws VortexException); primitive columns keep their own order, so an unsigned or floating column is unchanged whatever the operand. ZoneMapPruningTest checks each zone's decoded decimal bounds and the rows of nine filtered scans; DecimalBytePartsInteropIntegrationTest checks column stats on a vortex-jni file and on Java's own, and Java's filtered read of both. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV
dfa1
force-pushed
the
fix/583-decimal-zone-bounds
branch
from
November 8, 2026 07:45
667103b to
5e07ffd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #583 (does not close it).
columnStats()and its filters never pruned. It does now.Comparetook aBigDecimalas aNumberand compared the truncated long. Decimal and unresolved-column compares go by value; primitive columns keep their order (unsigned, floating) whatever the operand; NaN/Inf/text/null operands throwVortexException.CompareTest.Not in this PR: a Calcite decimal MIN/MAX push-down test; Rust-written decimal flat-node stats (
ArrayStats.decodeScalarreads them as text, predates this).🤖 Generated with Claude Code
https://claude.ai/code/session_011fRbYsrGtpKHp9APhU8qDV